Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SMART_PTRS_DEF to LifecyclePublisher #569

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Add SMART_PTRS_DEF to LifecyclePublisher #569

merged 1 commit into from
Oct 12, 2018

Conversation

cho3
Copy link
Contributor

@cho3 cho3 commented Oct 12, 2018 •
edited by Karsten1987
Loading

fixes #568

@tfoote tfoote added the in review Waiting for review (Kanban column) label Oct 12, 2018
@cho3 cho3 mentioned this pull request Oct 12, 2018
Closed
Karsten1987
Karsten1987 approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the patch.

for future references, you can add fixes followed by the link to your github issue to connect them. This will automatically close the issue the moment the PR gets merged.
I went ahead and modified your original message of this PR to give you an example.

@Karsten1987 Karsten1987 merged commit 144c24c into ros2:master Oct 12, 2018
@Karsten1987 Karsten1987 removed the in review Waiting for review (Kanban column) label Oct 12, 2018
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@y-okumura-isp
Fix alloc-dealloc-mismatch(new->free) in test_info_by_topic (ros2#469) (
ec43777 
ros2#569)

Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LifecyclePublisher doesn't have smart pointer definitions
3 participants
@cho3 @Karsten1987 @tfoote