delete TRANSITION_SHUTDOWN #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
approved these changes
Oct 30, 2018
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…os2#576) * Use a single executor in the wait_for utility to put less strain on the global context shutdown * Don't copy around message pointers vectors, rather observe by const reference Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ros2/rcl#309
There's one extra remark on this one:
I added a little check when invoking a transition service call. It checks that when an
idas well aslabelfor the transition is given, it fetches the transition given the label and not the id.This enables service calls like
I can't sanity check the ids after I fetching the transition by label because
ros2 service call ...defaults all values, in that case theidto zero.