Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind is no longer in std::__1 #618

Merged
merged 1 commit into from Jan 14, 2019
Merged

Bind is no longer in std::__1 #618

merged 1 commit into from Jan 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2019

The namespace of the __bind function in llvm is now in std and not std::__1

@kuzai
Bind is no longer in std::__1
d2c8a2e 
Signed-off-by: kuzai <kuzai@users.noreply.github.com>
@tfoote tfoote added the in review Waiting for review (Kanban column) label Jan 11, 2019
wjwwood
wjwwood approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch works on my mac (High Sierra, Apple LLVM version 10.0.0 (clang-1000.11.45.5)).

@wjwwood
Copy link
Member

wjwwood commented Jan 14, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member

wjwwood commented Jan 14, 2019

Thanks!

@wjwwood wjwwood merged commit 1e91fac into ros2:master Jan 14, 2019
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jan 14, 2019
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
@kuzai @christopherho-ApexAI
Bind is no longer in std::__1 (ros2#618)
5f6df83 
Signed-off-by: kuzai <kuzai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wjwwood @tfoote @kuzai