Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on rclpy from rclcpp_lifecycle #626

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Feb 5, 2019

Not sure why it was there in the first place...

It has been there since the original commit adding lifecycle stuff.

Not sure why it was there in the first place...

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Feb 5, 2019
@wjwwood wjwwood self-assigned this Feb 5, 2019
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it's there. makes total sense to remove.

@wjwwood
Copy link
Member Author

wjwwood commented Feb 5, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit c7ac39a into master Feb 6, 2019
@wjwwood wjwwood deleted the wjwwood-patch-1 branch February 6, 2019 00:02
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Feb 6, 2019
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
Not sure why it was there in the first place...

Signed-off-by: William Woodall <william@osrfoundation.org>
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants