Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo explicit blacklist in Python implementation selection #11

Closed
wjwwood opened this issue Apr 6, 2016 · 4 comments
Closed

undo explicit blacklist in Python implementation selection #11

wjwwood opened this issue Apr 6, 2016 · 4 comments
Labels
enhancement New feature or request

Comments

@wjwwood
Copy link
Member

wjwwood commented Apr 6, 2016

Undo #10.

Instead we should:

@wjwwood wjwwood added the enhancement New feature or request label Apr 6, 2016
@jacquelinekay
Copy link
Contributor

jacquelinekay commented Apr 6, 2016

Blacklist/whitelist-related issues to fix in rosidl_generator_py:

@jacquelinekay
Copy link
Contributor

Is this ticket closeable? I believe recent changes using the ament_index have fixed the blacklisting problems in this repo.

@wjwwood
Copy link
Member Author

wjwwood commented May 4, 2016

I guess so.

@wjwwood wjwwood closed this as completed May 4, 2016
@wjwwood
Copy link
Member Author

wjwwood commented May 4, 2016

Well, actually we haven't de-duplicated the logic for selecting the default rmw implementation. It's duplicated here:

https://github.com/ros2/rclpy/blob/master/rclpy/rclpy/impl/rmw_implementation_tools.py#L89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants