-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to get remapped service name #1156
Support to get remapped service name #1156
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@iuhilnehc-ynos can i use another review? if you are good to go, please start the CI. |
Yeah. This style is also what I expected. Please see rclpy/rclpy/rclpy/publisher.py Lines 81 to 84 in 1843c22
I prefer to use a new property named 'service_name' for the Service and Client. BTW. I have no idea if users want to use the original |
@iuhilnehc-ynos Thanks for your comments. |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
f3a3309
to
6ad29e8
Compare
Signed-off-by: Barry Xu <barry.xu@sony.com>
Address #954
srv_name
in service & client save real service name (remapped name).