Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to get remapped service name #1156

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

Barry-Xu-2018
Copy link
Contributor

Address #954

srv_name in service & client save real service name (remapped name).

@Barry-Xu-2018
Copy link
Contributor Author

srv_name isn't set as the property of service & client.
So maybe it is better to make new property service_name for service & client class to save real service name. srv_name only save service name input by user.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rclpy/rclpy/node.py Outdated Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator

@iuhilnehc-ynos can i use another review? if you are good to go, please start the CI.

@iuhilnehc-ynos
Copy link
Contributor

srv_name isn't set as the property of service & client. So maybe it is better to make new property service_name for service & client class to save real service name. srv_name only save service name input by user.

Yeah. This style is also what I expected. Please see

@property
def topic_name(self) -> str:
with self.handle:
return self.__publisher.get_topic_name()

I prefer to use a new property named 'service_name' for the Service and Client.

BTW. I have no idea if users want to use the original srv_name passed into Service and Client even though there aren't relative names in the Publisher and Subscriber. Let's just keep it.

@Barry-Xu-2018
Copy link
Contributor Author

Barry-Xu-2018 commented Aug 29, 2023

@iuhilnehc-ynos Thanks for your comments.
I will update codes to use new property service_name for service & client class, like the implementation of publisher.py.

Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
@iuhilnehc-ynos
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 03bcc32 into ros2:rolling Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants