Add timeout to executor_spin_until_future_complete #301
Conversation
Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
rclpy/test/test_executor.py
Outdated
|
|
||
| def timer_callback(): | ||
| pass | ||
| timer = self.node.create_timer(0.1, timer_callback) |
There was a problem hiding this comment.
Why do we need to create a timer? Is this so that the underlying spin_once will return (ie not timeout) and we can check the future? Seems like the spin_until_future_complete logic could be improved by not making it rely on other callbacks. This type of improvement does not have to happen in this PR since it looks like it has always been this way.
There was a problem hiding this comment.
Right, spin_until_future_complete has underlying spin_once needed to return like rclcpp.
Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
vinnamkim
force-pushed
the
spin_until_future_complete
branch
from
a06cbca
to
933049a
Compare
|
@jacobperron Thanks for review. updated commit. |
|
Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
|
Wndows: |
|
@vinnamkim Sorry, a recent merge to master seems to have caused conflicts. For future, a rebase instead of a merge should help avoid this. After the conflict is resolved I'll merge this PR, thanks! |
Fix #261.
Signed-off-by: vinnamkim vinnam.kim@gmail.com