New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The message type to update TimeSource is inconsistent with rclcpp #303

Closed

vinnamkim opened this issue Apr 2, 2019 · 1 comment

Labels

bug good first issue help wanted

Contributor

vinnamkim commented Apr 2, 2019

rclpy uses builtin_interfaces.msg.Time to update ROS time. However, rclcpp uses rosgraph_msgs::msg::Clock. I think they should be same, and rosgraph_msgs::msg::Clock would be more preferred likewise ROS1. Is it?

tfoote added bug good first issue help wanted labels

Contributor

tfoote commented Apr 2, 2019

Yes, this should be switched to use rosgraph_msgs/Clock like rclcpp and ROS1.

The same change was made in rclcpp here: ros2/rclcpp#474

vinnamkim mentioned this issue

Use rosgraph_msgs.msg.Clock for TimeSource #304

Merged

tfoote added the in review label

sloretz closed this as completed in #304

sloretz removed the in review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment