Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameter options #363

Merged
merged 5 commits into from
May 29, 2019
Merged

Rename parameter options #363

merged 5 commits into from
May 29, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 28, 2019

@wjwwood
rename the initial_parameters option to parameter_overrides
e2293b2 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
rename automatically_declare_initial_parameters to automatically_decl…
fca845b 
…are_parameters_from_overrides

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label May 28, 2019
@wjwwood wjwwood self-assigned this May 28, 2019
@wjwwood wjwwood mentioned this pull request May 28, 2019
Merged
@wjwwood wjwwood requested a review from jubeira May 28, 2019 22:01
jubeira
jubeira approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it's a good change in an effort to clarify this detail.
I've just left a suggestion for your consideration.

rclpy/rclpy/node.py Show resolved Hide resolved
chapulina
chapulina reviewed May 28, 2019
View reviewed changes
rclpy/rclpy/__init__.py Outdated Show resolved Hide resolved
rclpy/rclpy/node.py Show resolved Hide resolved
@wjwwood @chapulina
update allow_undeclared_parameters docs
4c52fe6 
Signed-off-by: William Woodall <william@osrfoundation.org>

Co-Authored-By: chapulina <louise@openrobotics.org>
wjwwood
wjwwood commented May 28, 2019
View reviewed changes
rclpy/rclpy/__init__.py Outdated Show resolved Hide resolved
@wjwwood
make default for automatically_declare_parameters_from_overrides cons…
78bc9f4 
…istent

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
touch docs to fix flake8
d0b3b0b 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood merged commit b460f51 into master May 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the rename_parameter_options branch May 29, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubeira jubeira jubeira approved these changes

@chapulina chapulina chapulina approved these changes

Assignees

@wjwwood wjwwood

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wjwwood @jubeira @chapulina