Expand test timeout to deflake rmw_connext #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a test local to my laptop, two test exceed the current 60 second timeout: test_executor ..................... Passed 61.35 sec test_node ......................... Passed 103.98 sec And one is marginal: test_time_source .................. Passed 54.96 sec Signed-off-by: Michael Carroll <michael@openrobotics.org>
dirk-thomas
approved these changes
Oct 23, 2019
|
|
|
A duplicate of #448 ? Either is fine, let's see which one is less flaky :) |
|
Whoops, didn't see that you had opened that, I found that you're going to need > 100 seconds in some cases, so your threshold may not be enough. |
suab321321
pushed a commit
to suab321321/rclpy
that referenced
this pull request
Jan 31, 2020
Based on a test local to my laptop, two test exceed the current 60 second timeout: test_executor ..................... Passed 61.35 sec test_node ......................... Passed 103.98 sec And one is marginal: test_time_source .................. Passed 54.96 sec Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see any duplication as in other tests, the following are just very substantial test files.
Based on a test local to my laptop, two test exceed the current 60 second timeout:
And one is marginal:
Signed-off-by: Michael Carroll michael@openrobotics.org