Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sizes to Py_ssize_t #514

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Change sizes to Py_ssize_t #514

merged 1 commit into from
Feb 25, 2020

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Feb 24, 2020

Fixes CI issue http://build.ros2.org/user/rotu/my-views/view/CycloneDDS/job/Fci__nightly-cyclonedds_ubuntu_focal_amd64/lastSuccessfulBuild/testReport/junit/rclpy.src.ros2.rclpy.rclpy.test/test_serialization/test_serialize_deserialize_msgs7_MultiNested_/

message = test_msgs.msg.MultiNested(array_of_arrays=[test_msgs.msg.Arrays(bool_values=[False, True, False], byte_values=[b'\x00'...values_default=[0, 1, 18446744073709551615], string_values_default=['', 'max value', 'min value'], alignment_check=2)])

    def serialize_message(message) -> bytes:
        """
        Serialize a ROS message.

        :param message: The ROS message to serialize.
        :return: The serialized bytes.
        """
        message_type = type(message)
        # this line imports the typesupport for the message module if not already done
        check_for_type_support(message_type)
>       return _rclpy.rclpy_serialize(message, message_type)
E       DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats

../../src/ros2/rclpy/rclpy/rclpy/serialization.py:29: DeprecationWarning

Signed-off-by: Dan Rose dan@digilabs.io

Fixes CI issue http://build.ros2.org/user/rotu/my-views/view/CycloneDDS/job/Fci__nightly-cyclonedds_ubuntu_focal_amd64/lastSuccessfulBuild/testReport/junit/rclpy.src.ros2.rclpy.rclpy.test/test_serialization/test_serialize_deserialize_msgs7_MultiNested_/

```
message = test_msgs.msg.MultiNested(array_of_arrays=[test_msgs.msg.Arrays(bool_values=[False, True, False], byte_values=[b'\x00'...values_default=[0, 1, 18446744073709551615], string_values_default=['', 'max value', 'min value'], alignment_check=2)])

    def serialize_message(message) -> bytes:
        """
        Serialize a ROS message.

        :param message: The ROS message to serialize.
        :return: The serialized bytes.
        """
        message_type = type(message)
        # this line imports the typesupport for the message module if not already done
        check_for_type_support(message_type)
>       return _rclpy.rclpy_serialize(message, message_type)
E       DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats

../../src/ros2/rclpy/rclpy/rclpy/serialization.py:29: DeprecationWarning
```

Signed-off-by: Dan Rose <dan@digilabs.io>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@jacobperron
Copy link
Member

jacobperron commented Feb 25, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

Edit: The test_timer failures are also present on the nightly windows-container build.

@jacobperron jacobperron merged commit b27ddc6 into ros2:master Feb 25, 2020
@rotu rotu deleted the pr-1 branch March 5, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants