Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Context.__context to None in __init__ #812

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Set Context.__context to None in __init__ #812

merged 1 commit into from
Aug 12, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 11, 2021 •
edited
Loading

Follow up to #803 (comment)

marking as Draft because I didn't test this locally edit: ready for review - testing rclpy on CI: Build Status

@sloretz
Set Context.__context to None in __init__
212e140 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz mentioned this pull request Aug 11, 2021
Merged
@sloretz sloretz marked this pull request as ready for review August 11, 2021 20:27
@sloretz
Copy link
Contributor Author

sloretz commented Aug 11, 2021

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz requested a review from hidmic August 11, 2021 20:29
@sloretz
Copy link
Contributor Author

sloretz commented Aug 12, 2021

Thanks for the review!

@sloretz sloretz merged commit a6aac56 into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the context_internal_variable_set_to_none branch August 12, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @fujitatomoya