Included get_available_rmw_implementations #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/feature/added_get_available_rmw_implementations
branch
from
30b4e2d
to
bb6a939
Compare
This was referenced Feb 27, 2020
dirk-thomas
approved these changes
Feb 27, 2020
wjwwood
approved these changes
Feb 27, 2020
|
Testing
Unrelated test failures. Merging |
delete-merged-branch
bot
deleted the
ahcorde/feature/added_get_available_rmw_implementations
branch
ivanpauno
reviewed
Mar 3, 2020
| @@ -18,6 +18,8 @@ | |||
| from rclpy.constants import S_TO_NS | |||
| from rclpy.context import Context | |||
|
|
|||
| import ament_index_python | |||
There was a problem hiding this comment.
flake8 is showing a failure, because this isn't imported in the correct order (the failure didn't appear in CI because rclpy was missing in the packages to be tested). @ahcorde Can you send a PR correcting it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in these PRs ros2/ros2cli#460, ros2/rmw_implementation#85 and ros2/rmw_implementation#84 I included in rclpy the utility function
get_available_rmw_implementations()