Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase rcutils line testing coverage #208

Merged
merged 35 commits into from
Mar 4, 2020
Merged

Increase rcutils line testing coverage #208

merged 35 commits into from
Mar 4, 2020

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Feb 13, 2020 •
edited
Loading

Add missing tests aiming to get rcutils to package level 1, this PR increases line coverage from 84% to 92%, some tests are waiting for #206.

Line Coverage on master: Coverage results
Line Coverage on this branch: Coverage results

@Blast545 Blast545 self-assigned this Feb 13, 2020
@Blast545 Blast545 added the enhancement New feature or request label Feb 13, 2020
@Blast545
Add tests for allocator.c failed cases
941848e 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests to array_list submodule, increasing coverage
70b1947 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add missing tests for test_char_array submodule
eaf8ddd 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests for cmdline_parser.c
9066226 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Fix bug, cmdline_parser accesing element out of array
7517e0f 
When the function matches the option exactly in the last
element, tries to acces an element outise the array
to check if it's NULL. Current implementation checks
for the end of the array using the passed end as reference.

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Reformat to cover the expected cases for not null
c209235 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add some test cases for submodule filesystem
f9a9cd2 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add missing test for rcutils_get_home_dir
f0d1d7d 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests for process module
540c495 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add some tests for logging.c submodule
d11a9c6 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add test missing in uint8_array.c
a5fadd1 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add missing tests for snprintf.c
e3cb104 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests missing for strdup.c
3d0ec67 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests for split.c functions
e1ede51 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add missing function in failing allocator
cd6d68e 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests for string_array type
9f8721e 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add missing test for array_list type
be0f792 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Fix lint issues
fbdd71d 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add missing test for error_handling module
91752a2 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add bad allocator test to hash_map init
dcfd137 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests for hash_map type
396fb8b 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests for string_map type
1b532d5 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Remove WIP to be completed in other test module
d6ca490 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add env vars testing all output handlers
38759b8 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 force-pushed the blast545/increase_coverage branch 2 times, most recently from f03ea41 to 38759b8 Compare February 14, 2020 18:54
hidmic
hidmic reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, nice improvements @Blast545 !

src/cmdline_parser.c Outdated Show resolved Hide resolved
test/test_allocator.cpp Outdated Show resolved Hide resolved
test/test_array_list.cpp Outdated Show resolved Hide resolved
test/test_char_array.cpp Outdated Show resolved Hide resolved
test/test_char_array.cpp Outdated Show resolved Hide resolved
test/test_logging.cpp Outdated Show resolved Hide resolved
test/test_logging_custom_env.cpp Outdated Show resolved Hide resolved
test/test_process.cpp Outdated Show resolved Hide resolved
test/test_snprintf.cpp Outdated Show resolved Hide resolved
test/test_split.cpp Outdated Show resolved Hide resolved
@Blast545
Address peer review comments from hidmic
8b40272 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from hidmic February 19, 2020 13:41
@Blast545
Remove not needed nullity check
d3490a8 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
hidmic
hidmic approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's looking good @Blast545 ! I'd like to see green CI too

test/test_char_array.cpp Outdated Show resolved Hide resolved
test/test_char_array.cpp Outdated Show resolved Hide resolved
test/test_char_array.cpp Outdated Show resolved Hide resolved
test/test_cmdline_parser.cpp Outdated Show resolved Hide resolved
test/test_cmdline_parser.cpp Outdated Show resolved Hide resolved
test/test_process.cpp Outdated Show resolved Hide resolved
@Blast545
Address style changes
c817206 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Adjust copyright issues
db5746c 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Rollback to use memcpy instead of strcpy
14c2118 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add check for buffer size, avoid problems with size=0
46fa85d 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Increase huge number fail test
832b299 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Increase huge number used to test array allocation failure
5b8a9cb 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Replace memcpy function with snprintf equivalent
ca552c5 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Remove not portable test
c01b02e 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Contributor Author

Blast545 commented Mar 3, 2020

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 requested a review from hidmic March 4, 2020 15:10
hidmic
hidmic approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for one comment.

test/test_char_array.cpp Outdated Show resolved Hide resolved
@Blast545
Change using constant for hardcoding buffer size
1ef9d09 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 merged commit 70d828c into master Mar 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/increase_coverage branch March 4, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@Blast545 Blast545

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blast545 @hidmic