Set hints to find the python version we actually want. #451
Conversation
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
This one can go in independently of the rest, so running CI on just this:
|
|
The one failing test on Windows Debug seems to be a bit of a flake, and unrelated to this. So going ahead and merging. |
delete-merged-branch
bot
deleted the
clalancette/remove-python-cmake-module
branch
)" This reverts commit 24431ba.
|
FYI, this breaks compatibility with some micro-ROS platforms due to the new CMake version: https://github.com/micro-ROS/micro_ros_espidf_component/actions/runs/7968336489/job/21754309794. Why is Python required for this package? |
There are apparently some logging macros installed by this package: https://github.com/ros2/rcutils/blob/rolling/rcutils/logging.py That said, we already require CMake 3.20+ almost across the board in https://www.ros.org/reps/rep-2000.html#jazzy-jalisco-may-2024-may-2029 (we'll be updating the places where we aren't; thanks for the reminder). And we'll be taking advantage of that in other places, like in ament/ament_cmake#508 . So I think those platforms are going to have to be updated one way or the other. |
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
)" This reverts commit 24431ba.
The comment in the commit explains the reasoning behind it.
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.