Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeFiles.txt lib dir is fixed #459

Closed
jiangqii opened this issue Apr 8, 2024 · 1 comment
Closed

CMakeFiles.txt lib dir is fixed #459

jiangqii opened this issue Apr 8, 2024 · 1 comment

Comments

@jiangqii
Copy link

jiangqii commented Apr 8, 2024

install(TARGETS ${PROJECT_NAME} EXPORT ${PROJECT_NAME}
  ARCHIVE DESTINATION lib
  LIBRARY DESTINATION lib
  RUNTIME DESTINATION bin)

This is not a dynamic change, it is recommended to use variables from cmake

install(TARGETS ${PROJECT_NAME} EXPORT ${PROJECT_NAME}
  ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
  LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
  RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
@clalancette
Copy link
Contributor

This is not a dynamic change, it is recommended to use variables from cmake

From what I understand, we can only do this if we use GNUInstallDirs, which we don't currently do. We've had some discussions about switching to this (see ros2/ros2#1465), but we haven't gotten there yet.

I'm going to close this as a duplicate of ros2/ros2#1465

@clalancette clalancette closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants