Add definition of separator used for logger names #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcutils logging has logger names as "a.b.c". this breaks out the dot separator so it doesn't have to be hard-coded here and elsewhere. For example, in rcl, we are using the separator when changing
/namespace/node
to logger namenamespace.node
.Since some callers might want a char literal (e.g here) and some might want a string literal so it's null terminated (e.g. here), I've provided definitions for both. This seems like a bit of an unusual thing to do though, so I'm open to alternatives 😄