Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of separator used for logger names #92

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

dhood
Copy link
Member

@dhood dhood commented Feb 22, 2018

rcutils logging has logger names as "a.b.c". this breaks out the dot separator so it doesn't have to be hard-coded here and elsewhere. For example, in rcl, we are using the separator when changing /namespace/node to logger name namespace.node.

Since some callers might want a char literal (e.g here) and some might want a string literal so it's null terminated (e.g. here), I've provided definitions for both. This seems like a bit of an unusual thing to do though, so I'm open to alternatives 😄

@dhood dhood added the in review Waiting for review (Kanban column) label Feb 22, 2018
@dhood dhood self-assigned this Feb 22, 2018
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, +1

@dhood
Copy link
Member Author

dhood commented Feb 23, 2018

CI on this was included in ros2/rcl#212 (comment)

@dhood dhood merged commit c6e6377 into master Feb 23, 2018
@dhood dhood deleted the node_logger_name branch February 23, 2018 19:22
@dhood dhood removed the in review Waiting for review (Kanban column) label Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants