Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about asynchronicity of discovery. #352

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Add a note about asynchronicity of discovery. #352

merged 1 commit into from
Apr 3, 2023

Conversation

clalancette
Copy link
Contributor

@clalancette
Add a note about asynchronicity of discovery.
20dee29 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette mentioned this pull request Apr 3, 2023
Closed
fujitatomoya
fujitatomoya approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

Ah, @clalancette i just started the CI at the same time... 😅

@clalancette
Copy link
Contributor Author

Ah, @clalancette i just started the CI at the same time... sweat_smile

Yeah, sorry. I canceled mine.

@clalancette clalancette added this to In progress in Iron Irwini via automation Apr 3, 2023
@clalancette clalancette merged commit bb044d5 into rolling Apr 3, 2023
Iron Irwini automation moved this from In progress to Done Apr 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the clalancette/add-async-note branch April 3, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@eboasson eboasson Awaiting requested review from eboasson

@iuhilnehc-ynos iuhilnehc-ynos Awaiting requested review from iuhilnehc-ynos

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Iron Irwini
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @fujitatomoya