Dynamic Subscription (BONUS: Allocators): rmw #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
a78630e
to
b79ec2a
Compare
28 tasks
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
b79ec2a
to
632e515
Compare
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
632e515
to
91b1dc7
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
wjwwood
approved these changes
Apr 10, 2023
| @@ -57,9 +59,10 @@ rmw_take_dynamic_message_with_info( | |||
| RMW_PUBLIC | |||
| RMW_WARN_UNUSED | |||
| rmw_ret_t | |||
| rmw_get_serialization_support( | |||
| rmw_init_serialization_support( | |||
There was a problem hiding this comment.
nit: wouldn't this be rmw_serialization_support_init by other convention?
There was a problem hiding this comment.
Oof, yes, I can change it
There was a problem hiding this comment.
Change is rolled out across the stack!
Signed-off-by: methylDragon <methylDragon@gmail.com>
clalancette
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ros2/ros2#1405