Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary c++14 flag. #360

Merged
merged 1 commit into from Nov 13, 2023
Merged

Remove unnecessary c++14 flag. #360

merged 1 commit into from Nov 13, 2023

Conversation

clalancette
Copy link
Contributor

No description provided.

@clalancette
Remove unnecessary c++14 flag.
02fad5c 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@ahcorde
Copy link
Contributor

ahcorde commented Nov 13, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@clalancette clalancette merged commit 9ad0ac4 into rolling Nov 13, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/update-to-c++17 branch November 13, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clalancette @ahcorde @fujitatomoya