add topic endpoint info to rmw #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#186 introduces two functions to the RMW interface which are not present when including `rmw/rmw.h`. For convenience to the rmw implementer, I think it makes sense to include all functions when including `rmw/rmw.h`.
|
I'm not quite in favor of "huge" headers, as they make compilation times much slower. |
|
@ivanpauno @Karsten1987 @wjwwood should we close this issue? I assume it's no longer relevant. |
There was a problem hiding this comment.
I will go ahead to close this. user can include the header if they want to use introspection of ROS graph and with #207 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#186 introduces two functions to the RMW interface which are not present when including
rmw/rmw.h.For convenience to the rmw implementer, I think it makes sense to include all functions when including
rmw/rmw.h.