Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing target dependency on rosidl_runtime_c #220

Merged
merged 1 commit into from
Apr 23, 2020
Merged

fix missing target dependency on rosidl_runtime_c #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rmw/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ if(BUILD_TESTING)
endif()

ament_export_development_version_if_higher_than_manifest("0.8.2-dev")
ament_package(CONFIG_EXTRAS "rmw-extras.cmake")
ament_package(
CONFIG_EXTRAS "rmw-extras.cmake"
CONFIG_EXTRAS_POST "rmw-extras-post.cmake")

install(
DIRECTORY cmake
Expand Down
20 changes: 20 additions & 0 deletions rmw/rmw-extras-post.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Copyright 2020 Open Source Robotics Foundation, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# copied from rmw/rmw-extras-post.cmake

# since a build dependency for the rosidl_runtime_c targets is undesired
# they are being added to the rmw interface library here instead
ament_target_dependencies(rmw::rmw INTERFACE
rosidl_runtime_c)
Copy link
Member Author

@dirk-thomas dirk-thomas Apr 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't compatible with CMake versions < 3.13. See the last bullet in https://cmake.org/cmake/help/v3.16/release/3.13.html#commands (https://cmake.org/cmake/help/v3.16/policy/CMP0079.html).

The error message looks like this:

CMake Error at install/ament_cmake_target_dependencies/share/ament_cmake_target_dependencies/cmake/ament_target_dependencies.cmake:96 (target_link_libraries):
  Cannot specify link libraries for target "rmw::rmw" which is not built by
  this project.

Depending on what is being built it can happen in different packages: