This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add rmw_*_event_init() functions #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
This was referenced Mar 17, 2020
wjwwood
reviewed
Mar 17, 2020
Signed-off-by: Miaofei <miaofei@amazon.com>
wjwwood
approved these changes
Mar 17, 2020
ivanpauno
approved these changes
Mar 17, 2020
| */ | ||
| RMW_CONNEXT_SHARED_CPP_PUBLIC | ||
| rmw_ret_t | ||
| __rmw_init_event( |
There was a problem hiding this comment.
A bit unrelated because it's extensively used in this package, function names starting with a leading underscore or containing __ should be avoided, as those names are reserved by the standard.
See ros2/rcl#597 (comment).
There was a problem hiding this comment.
We can do a separate pull request that changes all the function names in this repo consistently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/ros2#822
This adds the
rmw_publisher_event_init()andrmw_subscription_event_init()functions tormw_connext, moved fromrmw, so that these functions will be able to check for whether or not the given type ofrmw_event_type_tis supported by the chosen middleware.