-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
52f25b6
to
532132f
Compare
"-Wno-return-type-c-linkage " | ||
"-Wno-sometimes-uninitialized " | ||
"-Wno-tautological-compare " | ||
"-Wno-unused-variable " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string values should not have a trailing space inside. Same below for the GNU flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I did this it would pass the flags to gcc all concatenated together. See (search for unrecognized command line option
):
http://54.183.26.131:8080/job/ros2_batch_ci_linux/124/consoleFull
cc1plus: warning: unrecognized command line option "-Wno-tautological-compare-Wno-return-type-c-linkage-Wno-deprecated-register" [enabled by default]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The set
command creates a list here. This implies that the items are separated by a semicolon. Therefore each item should not have a trailing space.
The additional problem here is that the replace call in line 79 has a bug and does not what it is supposed to do, namely replace these semicolons with space. That is because the value of the replace call is not quoted. It should be:
string(REPLACE ";" " " _connext_compile_flags "${_connext_compile_flags}")
This will also suppress warnings in the code the |
You can put |
Sounds good. I can update the CMake block after we merged the refactoring PR and only apply the properties for the generated files coming from the Connext code generator. |
a8a0494
to
b49d111
Compare
Fixes some warnings (hopefully) about unknown pragmas and arguments. See:
ee775b8#commitcomment-11295655
Connects to ros2/ros2#53