Pass parameters in the correct order to DDS_DataReader_read in rmw_co… #129
Conversation
…nnextdds_count_unread_samples for micro Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
There was a problem hiding this comment.
As far as I can tell, this has always been wrong; even on Connext Pro, the API seems to be:
DDS_DataReader_read(DDS_DataReader, DDS_UntypedSampleSeq, DDS_SampleInfoSeq, DDS_Long, DDS_SampleStateMask, DDS_ViewStateMask, DDS_InstanceStateMask)
So this looks good to me. I'm going to run CI on it, but @asorbini I could really use a double-check here to make sure that we're doing the right thing with this change.
|
CI:
|
|
I'm going to go ahead and merge this since it seems right. If there are any follow-up comments we can deal with them later. |
|
This Fix really should be backported to humble. |
We can backport it to Humble (and Iron), but I'd rather wait a bit here to see if anything pops up in Rolling first. While I don't think that will be the case, we did in fact change the bitmasks that are being passed. So I want to make sure we didn't break anything. |
|
@clalancette please not that due to #127 no one will be ablt to test these changes on the rolling branch since it won't even compile. This patch (and #130 as well BTW) will just work on humble as there is not build issue. |
…nnextdds_count_unread_samples for micro.
The order of parameters is now consistent with the respective function call for Connext Pro.