Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RMW_Connext_Client::is_service_available for micro #130

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix RMW_Connext_Client::is_service_available for micro #130

merged 1 commit into from
Aug 7, 2023

Conversation

cwecht
Copy link
Contributor

@cwecht cwecht commented Aug 3, 2023

Fixed #128.

clalancette
clalancette requested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please target this at the rolling branch first? We can backport it from there.

@cwecht cwecht force-pushed the fix-Client-is_service_available-micro branch from 969171a to c7e464b Compare August 4, 2023 06:35
@cwecht cwecht changed the base branch from humble to rolling August 4, 2023 06:35
@cwecht
Copy link
Contributor Author

cwecht commented Aug 4, 2023

rebase done.

clalancette
clalancette requested changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit to fix, then I think this will be good to run CI on.

rmw_connextdds_common/src/common/rmw_impl.cpp Outdated Show resolved Hide resolved
@cwecht
Fix RMW_Connext_Client::is_service_available for micro
e995625 
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
@cwecht cwecht force-pushed the fix-Client-is_service_available-micro branch from c7e464b to e995625 Compare August 7, 2023 06:27
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 9815505 into ros2:rolling Aug 7, 2023
1 check passed
@cwecht cwecht mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Services are broken if using connext micro
2 participants
@cwecht @clalancette