Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rmw_get_gid_for_client impl #92

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Conversation

ihasdapie
Copy link
Member

See: ros2/rmw#327

Keeping as draft for now since I don't have connextdds locally to test.

Signed-off-by: Brian Chen brian.chen@openrobotics.org

Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
A minor change to make the change build successfully.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron marked this pull request as ready for review September 19, 2022 20:30
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobperron jacobperron merged commit aa7e22b into rolling Sep 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the brianc/rmw_get_gid_for_client branch September 23, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants