Updated error returns on rmw_take #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blast545
reviewed
Sep 14, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
hidmic
reviewed
Sep 15, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
hidmic
approved these changes
Sep 18, 2020
|
Updated jobs:
|
hidmic
approved these changes
Sep 18, 2020
|
This change introduced several test failures downstream (for example). Locally, if I revert this PR then tests start passing again. @Lobotuerk For future, we should run CI for all packages when making changes to an RMW implementation. |
jacobperron
added a commit
that referenced
this pull request
Sep 21, 2020
This reverts commit 90eaee8.
This also means that the corresponding test in |
hidmic
added a commit
that referenced
this pull request
Sep 21, 2020
Fix for regression introduced in #241. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added a commit
that referenced
this pull request
Sep 22, 2020
Fix for regression introduced in #241. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Fix for regression introduced in #241. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Fix for regression introduced in #241. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lobotuerk jtlorente@ekumenlabs.com