Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rmw_*_event_init() functions #115

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Add rmw_*_event_init() functions #115

merged 3 commits into from
Mar 19, 2020

Conversation

mm318
Copy link
Member

@mm318 mm318 commented Mar 17, 2020

Related to ros2/ros2#822

This adds the rmw_publisher_event_init() and rmw_subscription_event_init() functions to rmw_cyclonedds, moved from rmw, so that these functions will be able to check for whether or not the given type of rmw_event_type_t is supported by the chosen middleware.

Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me

Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved
Signed-off-by: Miaofei <miaofei@amazon.com>
@ivanpauno ivanpauno merged commit 025762a into ros2:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants