Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rmw_* return codes #246

Merged
merged 3 commits into from Sep 25, 2020
Merged

Updated rmw_* return codes #246

merged 3 commits into from Sep 25, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 23, 2020

Updated return codes for unimplemented rmw___allocation functions. Related with this PR ros2/rmw_implementation#137

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before merging, would you mind opening a PR against rmw to add this error code to the API spec?

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde changed the title Updated rmw_*_*_allocation return codes Updated rmw_* return codes Sep 24, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 25, 2020

Compiling and testing up-to rmw_cyclonedds.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor

hidmic commented Sep 25, 2020

CI up to test_rmw_implementation and rcl, against all Tier 1 RMW implementations:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 85c9c31 into master Sep 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/test/rmw_implementation branch September 25, 2020 15:32
ahcorde added a commit that referenced this pull request Oct 9, 2020
* Updated rmw_*_*_allocation return codes

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed return codes in rmw_*

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved return error in rmw_wait

Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 15, 2020
* Updated rmw_*_*_allocation return codes

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed return codes in rmw_*

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved return error in rmw_wait

Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants