Move the QD into the rmw_implementation subdirectory. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is more appropriate, as it only applies to that package. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
hidmic
reviewed
Jun 26, 2020
There was a problem hiding this comment.
@clalancette just moving the file isn't enough -- there're plenty of local links in this declaration.
Also, I think the README.md should also be moved into the package. WDYT?
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Yep, good call. I think I've fixed them all in 90a690e.
Agreed. Also moved in 90a690e. |
hidmic
approved these changes
Jun 30, 2020
ahcorde
pushed a commit
that referenced
this pull request
Oct 27, 2020
* Move the QD into the rmw_implementation subdirectory. That is more appropriate, as it only applies to that package. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ahcorde
pushed a commit
that referenced
this pull request
Oct 28, 2020
* Move the QD into the rmw_implementation subdirectory. That is more appropriate, as it only applies to that package. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is more appropriate, as it only applies to that package.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org