Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rmw_connext_cpp. #183

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Remove rmw_connext_cpp. #183

merged 2 commits into from
Mar 25, 2021

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@clalancette
Remove rmw_connext_cpp.
e510fd2 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette mentioned this pull request Mar 24, 2021
Closed
@ivanpauno ivanpauno mentioned this pull request Mar 24, 2021
Merged
asorbini
asorbini approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@asorbini asorbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a follow up to #182

@asorbini
Copy link
Contributor

Actually, one minor addition: you might want to remove the reference to rmw_connext_cpp in test_rmw_implementation/test/config.hpp (I noticed this in my original edits)

@clalancette
Fixes from review.
4687ee4 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

Actually, one minor addition: you might want to remove the reference to rmw_connext_cpp in test_rmw_implementation/test/config.hpp (I noticed this in my original edits)

Good call, fixed in 4687ee4

@clalancette
Copy link
Contributor Author

CI for this is at ros2/rmw_connextdds#9 (comment) (the yellow jobs are because of an uncrustify error in rclcpp that has since been fixed). So I'm going to go ahead and merge this.

@clalancette clalancette merged commit 48f0999 into master Mar 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the clalancette/remove-rmw-connext-cpp branch March 25, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asorbini asorbini asorbini approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clalancette @asorbini @ivanpauno