Update rmw_implementation to C++17. #214
Conversation
The two reasons to do this are: 1. So that we can compile rmw_implementation with the clang static analyzer. As of clang++-14 (what is in Ubuntu 22.04), the default still seems to be C++14, so we need to specify C++17 so that new things in the rclcpp headers work properly. 2. So we can build with a newer version of gtest which requires this. Further, due to reasons I don't fully understand, I needed to set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use that version. So set this as well. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Yeah, I have a whole series of these queued up. See for example ros2/rosidl_typesupport#131 , ros2/rosidl_typesupport_fastrtps#94 , etc (and there are more that I haven't even opened yet).
Sorry, I don't quite understand this question. Can you rephrase? |
I just saw the two PRs, so that I came up with that question.
this answers my question too! thanks. |
You are welcome! CI for this is in ros2/rosidl_typesupport#131 (comment), and since that is green and this is approved, I'm going to merge it in. |
The two reasons to do this are:
Further, due to reasons I don't fully understand, I needed to set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use that version. So set this as well.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org