use format 3 #32
use format 3 #32
Conversation
dirk-thomas
added
in review
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0"?> | |||
| <?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> | |||
| <package format="2"> | |||
| <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> | |||
There was a problem hiding this comment.
When is it necessary for this file to exist? Which tools use it?
There was a problem hiding this comment.
I think right now nothing in the ROS eco-system (1 or 2) requires it. Actually tinyxml(2) just ignores any <?...?> tag.
More advanced parsers can use it and complain if the following xml string doesn't validate the provided schema.
There was a problem hiding this comment.
If you have your editor configured to lint xml files (e.g. in Atom using linter-xmllint) it will use the referenced schema. Since the schema is not yet final it isn't available through that URL but you can reference the file with a local file:// to point to the current version in the branch on the REP repo.
| <depend>rmw_fastrtps_cpp</depend> | ||
| <depend>rmw_opensplice_cpp</depend> |
There was a problem hiding this comment.
Implicitly the decision here is to release with an explicit dependency on fastrtps only. I guess if we build binaries with support for more we'd add the keys back here?
Perhaps a comment on the fastrtps dependency, indicating that it is there for packaging purposes and is redundant with the group dependency when building from source, would help people interpreting the package.xml in the future.
There was a problem hiding this comment.
👍 the absence of comment here is what led to my question of "if a user want to modify the defaut rmw_imp and build only for that one, do they need to modify this manifest?"
There was a problem hiding this comment.
Implicitly the decision here is to release with an explicit dependency on fastrtps only. I guess if we build binaries with support for more we'd add the keys back here?
Yes, this reflects what we did release in the past betas.
Perhaps a comment on the fastrtps dependency, indicating that it is there for packaging purposes and is redundant with the group dependency when building from source, would help people interpreting the
package.xmlin the future.
Can you please either propose a wording or commit the comment directly. Thanks.
if a user want to modify the defaut rmw_imp and build only for that one, do they need to modify this manifest
Nothing has changed here. The user places whatever rmw impl he wants to build into the workspace and if it is more than one and he doesn't use the default (which is FastRTPS if present otherwise the first in alphabetical order) it can be overridden by specifying the environment variable RMW_IMPLEMENTATION.
|
|
||
| <test_depend>ament_lint_auto</test_depend> | ||
| <test_depend>ament_lint_common</test_depend> | ||
|
|
||
| <group_depend>rmw_implementations</group_depend> |
There was a problem hiding this comment.
The group name was changed later in #36.
Connect to ament/ament_package#63