Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to get publisher actual qos settings #56

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Add function to get publisher actual qos settings #56

merged 1 commit into from
Apr 1, 2019

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Mar 25, 2019 •
edited by mjcarroll
Loading

Add new function ros2/rmw#169

Connects to ros2/rmw#169

@ivanpauno
Add function rmw_get_actual_qos
a4f0c5c 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno self-assigned this Mar 25, 2019
@ivanpauno ivanpauno added the in progress Actively being worked on (Kanban column) label Mar 25, 2019
hidmic
hidmic approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno ivanpauno mentioned this pull request Mar 27, 2019
Merged
@ivanpauno ivanpauno added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 1, 2019
@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit e7f84dd into master Apr 1, 2019
@ivanpauno ivanpauno removed the in review Waiting for review (Kanban column) label Apr 1, 2019
@ivanpauno ivanpauno deleted the ivanpauno/publisher_get_actual_qos branch April 1, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanpauno @mjcarroll @hidmic