Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Still build with shared lib loading support, even if there's only one? #58

Closed
EricCousineau-TRI opened this issue Mar 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Mar 25, 2019

At present, the current CMakeLists.txt seems a bit too implicit:
https://github.com/ros2/rmw_implementation/blob/c5f5324/rmw_implementation/CMakeLists.txt#L41-L44

Can this be made into an explicit CMake switch, something like -DFORWARD_RMW_IMPLEMENTATION={OFF,ON}?

Rationale:
I'm developing on a machine that only has one RMW implementation present.
In debugging stuff like ros2/rcpputils#3 and ros2/rcutils#143, it I couldn't just rebuild rmw_implementation to reproduce what I have installed as a binary.

The only way that I can reproduce the binary is either (a) modify CMakeLists.txt or (b) install an (unused) RMW implementation, which is odd... (example patch line)

I should be able reproduce this with my installed packages?

@dirk-thomas
Copy link
Member

Can this be made into an explicit CMake switch ...?

That sounds fine. I would suggest adding a boolean CMake option like RMW_IMPLEMENTATION_FORCE_POCO. Please consider creating a pull request for this.

@dirk-thomas dirk-thomas added the enhancement New feature or request label Mar 25, 2019
@tfoote tfoote added the in review Waiting for review (Kanban column) label Mar 26, 2019
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants