Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Python code #85

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Removed Python code #85

merged 1 commit into from
Mar 3, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 26, 2020

According with this discussion #84 (review) It makes sense to remove the Python dependency and call `ament_index_python.get_resources() where it's needed

@ahcorde
removed python code
83c8f7c 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Feb 26, 2020
@ahcorde ahcorde self-assigned this Feb 26, 2020
@ahcorde ahcorde mentioned this pull request Feb 26, 2020
Closed
This was referenced Feb 27, 2020
Merged
Merged
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 27, 2020

Moved get_available_rmw_implementations funtion to rclpy ros2/rclpy#517
and used in ros2cli ros2/ros2cli#461

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 28, 2020 •
edited
Loading

Testing

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 3, 2020

Unrelated test failures. Merging

@ahcorde ahcorde merged commit d52e3c0 into master Mar 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/feature/removed_python branch March 3, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @wjwwood @dirk-thomas