Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare dependencies for bouncy release. #41

Merged
merged 4 commits into from Jun 23, 2018
Merged

Prepare dependencies for bouncy release. #41

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9d0fa3
Prepare dependencies for bouncy release.
nuclearsandwich Jun 21, 2018
fe09dcf
Explain reasoning for duplicating group dependency declaration.
nuclearsandwich Jun 22, 2018
48261cd
Remove comment about packaging behavior.
nuclearsandwich Jun 22, 2018
2561413
update comment
dirk-thomas Jun 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions rmw_implementation/package.xml
View file
Open in desktop
Expand Up @@ -11,11 +11,22 @@

<build_depend>rcutils</build_depend>
<build_depend>rmw</build_depend>
<!-- Bloom does not support group_depend so entries below duplicate the group rmw_implementation_packages -->
<build_depend>rmw_connext_cpp</build_depend>
<build_depend>rmw_fastrtps_cpp</build_depend>
<build_depend>rmw_opensplice_cpp</build_depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should these be added upstream? The group dependency below already covers them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're redundant with upstream's use of the group tag so they don't change upstream behavior. The other dependency work for this repository will happen after package.xmls are handled so with these changes upstream no package.xml overlay is needed in the release repo.

But since they are redundant I can instead add them to an overlay or patch in the release repositor if that is preferred.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to add them here is that avoid patching the manifest in the release repo since it doesn't affect the behavior.

Please add a comment above these three line describing why they are in there.

<!-- end of group dependencies added for bloom -->

<depend>libpoco-dev</depend>
<depend>poco_vendor</depend>
<depend>rmw_implementation_cmake</depend>
<!--
Rather than a hard-dependency on any one rmw implementation.
The debian/control template for this package will be modified to depend on either
rmw_fastrtps_cpp or rmw_connext_cpp or rmw_opensplice_cpp with rmw_fastrtps_cpp being
the default choice if no other rmw implementation is currently installed.
<depend>rmw_fastrtps_cpp</depend>
-->

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>
Expand Down