Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

remove dependency of type support on rmw #39

Closed
dirk-thomas opened this issue Jun 15, 2015 · 2 comments
Closed

remove dependency of type support on rmw #39

dirk-thomas opened this issue Jun 15, 2015 · 2 comments
Labels
bug Something isn't working

Comments

@dirk-thomas
Copy link
Member

Currently rosidl_typesupport_opensplice_cpp includes rmw/rmw.h for the symbol rmw_request_id_t (

). It does not in the package.xml (and should not) depend on the rmw package. Therefore it fails to build with the --isolated options.

Instead the definition for the request header should come from a low-level package which also needs to provide that for every language we aim to support (e.g. C, C++).

The definition to generate the request / response data structure including the header is in the rosidl_generator_dds_idl package (https://github.com/ros2/rosidl_dds/blob/32c4c22ab6784ed245d5399d37ac09628fde6d2b/rosidl_generator_dds_idl/rosidl_generator_dds_idl/__init__.py#L93-L120).

@dirk-thomas dirk-thomas added the bug Something isn't working label Jun 15, 2015
@dirk-thomas
Copy link
Member Author

Considering to move the symbol to rosidl_generator_c.

@dirk-thomas
Copy link
Member Author

Since it is not likely that we will move this single symbol I will close this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant