Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ros/angles and ros-perception/laser_geometry #477

Merged
merged 1 commit into from Apr 3, 2018

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Mar 31, 2018

Connects to ros2/rviz#238

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Mar 31, 2018
@wjwwood wjwwood self-assigned this Mar 31, 2018
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhood
Copy link
Member

dhood commented Apr 3, 2018

merging to get builds working again

@dhood dhood merged commit d393e88 into master Apr 3, 2018
@dhood dhood deleted the feature/migrate_laser_scan_display branch April 3, 2018 15:34
@dhood dhood removed the in review Waiting for review (Kanban column) label Apr 3, 2018
@wjwwood
Copy link
Member Author

wjwwood commented Apr 3, 2018

Damn sorry, that’s the second time I’ve done that :/ thanks @dhood

@dhood
Copy link
Member

dhood commented Apr 3, 2018

no problem, easy fixed

@mikaelarguedas
Copy link
Member

@wjwwood It looks like the angles package is not required anymore ros-perception/laser_geometry@c029efc#diff-34ae68f4adad56c25c5bc05dcb64794e. Can we remove it from here ?
Should it be released anyway?

@wjwwood
Copy link
Member Author

wjwwood commented Jun 28, 2018

If it’s not required I guess we can remove it.

@mikaelarguedas
Copy link
Member

👍
I'll remove it from CI but release it in bouncy so that it's availab le to users and is tested on dev jobs. It just won't be tested on the other platforms anymore but will save some ci time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants