Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions for Dashing patch release 5. #840

Merged
merged 3 commits into from Dec 14, 2019
Merged

Update versions for Dashing patch release 5. #840

merged 3 commits into from Dec 14, 2019

Conversation

nuclearsandwich
Copy link
Member

@nuclearsandwich nuclearsandwich commented Dec 12, 2019 •
edited

Closes #804.

@nuclearsandwich
Update versions for patch release 5.
cd2c671 
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich added the in review Waiting for review (Kanban column) label Dec 12, 2019
@nuclearsandwich nuclearsandwich self-assigned this Dec 12, 2019
@nuclearsandwich

This comment has been minimized.

Sign in to view
@nuclearsandwich
Use commit instead of version number for cyclonedds.
7fe28ee 
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas
Copy link
Member

Shouldn't this wait until ros2/rclpy#481 has been resolved?

@nuclearsandwich
Copy link
Member Author

Shouldn't this wait until ros2/rclpy#481 has been resolved?

Sure but I hadn't seen it until I'd already started.

@nuclearsandwich nuclearsandwich added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Dec 12, 2019
@nuclearsandwich
Bump rclpy version to fix regression.
5d5d0a7 
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 12, 2019
@nuclearsandwich
Copy link
Member Author

ros2/rclpy#481 has been resolved with 0.7.10. This PR has been updated to include the fixed version.

@nuclearsandwich
Copy link
Member Author

nuclearsandwich commented Dec 13, 2019 •
edited

Fresh CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-armhf Build Status
  • macOS Build Status
  • Windows Build Status (restarted without cyclonedds)

@nuclearsandwich
Copy link
Member Author

nuclearsandwich commented Dec 14, 2019 •
edited

Linux + Linux arm64: Linter failures on CI are due to drift between older rosdistros and the current linter versions. I had tried to ignore most of them but typo'd a ctest argument. Other failures with cyclonedds and cross-vendor communication aren't release blockers.

Linux armhf: Looks mostly similar to arm64 with some additional issues but this isn't a release-blocking platform.

macOS: I was hoping to get lucky here since Dashing isn't supported on Mojave. I didn't.

Windows: Re-ran CI without CycloneDDS and am left with just linter issues.

@nuclearsandwich nuclearsandwich merged commit 020913f into dashing-release Dec 14, 2019
@nuclearsandwich nuclearsandwich deleted the dashing-patch-5 branch December 14, 2019 02:26
@nuclearsandwich nuclearsandwich mentioned this pull request Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nuclearsandwich nuclearsandwich

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuclearsandwich @dirk-thomas