Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mimick_vendor package to ros2.repos #985

Merged
merged 1 commit into from Jul 23, 2020
Merged

Add mimick_vendor package to ros2.repos #985

merged 1 commit into from Jul 23, 2020

Conversation

Blast545
Copy link
Contributor

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

@Blast545
Add mimick_vendor package to ros2.repos
67f44dd 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 self-assigned this Jul 22, 2020
@Blast545
Copy link
Contributor Author

Blast545 commented Jul 22, 2020 •
edited by hidmic

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 requested a review from hidmic July 22, 2020 13:59
hidmic
hidmic approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@Blast545 Blast545 mentioned this pull request Jul 23, 2020
Merged
@Blast545
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 merged commit 0acd33a into master Jul 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/add_mimick_vendor_repo branch July 23, 2020 18:54
@dirk-thomas
Copy link
Member

This breaks the Rolling CI builds (e.g. http://build.ros2.org/view/Rci/job/Rci__nightly-debug_ubuntu_focal_amd64/23/) since the package uses a key which is not a valid rosdep key: https://github.com/ros2/mimick_vendor/blob/7687045188b2329372ca2cf8c728370bb30f5a81/package.xml#L19

@Blast545 Please fix asap.

@Blast545 Blast545 mentioned this pull request Jul 23, 2020
Merged
@dirk-thomas
Copy link
Member

This change also introduced a CMake warning on Windows: https://ci.ros2.org/view/nightly/job/nightly_win_rel/1639/msbuild/

@Blast545 Please address.

@Blast545 Blast545 mentioned this pull request Jul 24, 2020
Merged
@hidmic
Copy link
Contributor

hidmic commented Jul 28, 2020

As noted by the referenced PRs, last regressions have been resolved.

ahcorde pushed a commit that referenced this pull request Oct 2, 2020
@Blast545 @ahcorde
Add mimick_vendor package to ros2.repos (#985)
24472ee 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
ahcorde added a commit that referenced this pull request Oct 2, 2020
@ahcorde @Blast545
Add mimick_vendor package to ros2.repos (#985) (#1041)
d080830 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>

Co-authored-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@Blast545 Blast545

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Blast545 @dirk-thomas @hidmic