New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TRACETOOLS_ prefix to tracepoint-related public macros #56
Add TRACETOOLS_ prefix to tracepoint-related public macros #56
Conversation
47d27e1
to
d614a0e
Compare
RMW is feature-frozen now, but if we merge this, then is it considered a bug fix to merge the corresponding |
Holding off on this until after Iron branches off from Rolling (April 24th). |
d614a0e
to
5281e3f
Compare
5281e3f
to
d03719a
Compare
This is ready for review. |
d03719a
to
c061403
Compare
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
c061403
to
ab83aca
Compare
@mjcarroll friendly ping for a review now that the Iron dust has settled a bit |
@christophebedard looks good, but we can probably use another round of CI as it has been over a month now. |
I see the same rclcpp.test_executors failure in a bunch of other I can only merge this PR, not the other ones. @mjcarroll if I merge this one, can you merge the other ones at the same time? |
Yep, I'm looking into that as well.
Yep, just shoot me a message when you are ready. |
Closes #18
This adds a
TRACETOOLS_
prefix to tracepoint-related public macros:TRACEPOINT()
,TRACEPOINT_ENABLED()
, andDO_TRACEPOINT()
. Since this is part of the public API, I left the current macros there and marked them as deprecated by defining and calling an empty deprecated function. Downstream PRs:It also adds a leading underscore to internal macros, especially in public headers.
Signed-off-by: Christophe Bedard bedard.christophe@gmail.com
action-ros-ci-repos-override: https://gist.githubusercontent.com/christophebedard/0f809c29f26685eaee9365a2f5bfaa17/raw/43889baefe7f2aa9803a5204a9c23c8c88d9e899/ros2.repos