Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tracing on Android #71

Merged
merged 1 commit into from May 2, 2023
Merged

Disable tracing on Android #71

merged 1 commit into from May 2, 2023

Conversation

Nizerlak
Copy link
Contributor

@Nizerlak Nizerlak commented Apr 26, 2023 •
edited

Similarly to #52, there was also an issue with building on android (following steps in this repo)
I've just simply applied same solution as in #53.

@Nizerlak Nizerlak force-pushed the rolling branch 2 times, most recently from 70442e2 to 7801002 Compare April 26, 2023 11:49
@christophebedard
Copy link
Member

christophebedard commented Apr 26, 2023 •
edited

Thanks for the PR! While I think installing LTTng on Android should be doable (unlike Windows), I think disabling it by default is reasonable.

We'll just have to wait until the Rolling freeze is lifted in a few days before merging. And then I think we could backport this to the new Iron branch as a bug fix.

I think GitHub is having some issues, so that might explain why some of the CI jobs are failing with weird errors.

@Nizerlak
Copy link
Contributor Author

Should I do anything more regarding this PR?

@Nizerlak Nizerlak mentioned this pull request Apr 27, 2023
Open
@christophebedard
Copy link
Member

Should I do anything more regarding this PR?

No, I'll pick it up once Rolling is unfrozen.

@christophebedard
Copy link
Member

Ah, one thing, though: the DCO check job is complaining because the commit author and the sign-off don't match:

  • Commit author: Przemysław Dąbrowski <57660090+Nizerlak@users.noreply.github.com>
  • Sign-off: Przemyslaw Dabrowski <57660090+Nizerlak@users.noreply.github.com>

Looks like the only difference is the ą/a. Would you mind changing the sign-off to match the commit author? Diacritics should be fine.

@Nizerlak
Disable tracing on Android
2963235 
Signed-off-by: Przemysław Dąbrowski <57660090+Nizerlak@users.noreply.github.com>
@christophebedard
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit 309a745 into ros2:rolling May 2, 2023
9 checks passed
@christophebedard
Copy link
Member

@Mergifyio backport iron

@mergify
Copy link

mergify bot commented May 2, 2023 •
edited

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 2, 2023
@Nizerlak @mergify
Disable tracing on Android (#71)
a199ba7 
Signed-off-by: Przemysław Dąbrowski <57660090+Nizerlak@users.noreply.github.com>
(cherry picked from commit 309a745)
@mergify mergify bot mentioned this pull request May 2, 2023
Merged
christophebedard pushed a commit that referenced this pull request May 3, 2023
@mergify @Nizerlak
Disable tracing on Android (#71) (#72)
9ac4c6b 
Signed-off-by: Przemysław Dąbrowski <57660090+Nizerlak@users.noreply.github.com>
(cherry picked from commit 309a745)

Co-authored-by: Przemysław Dąbrowski <57660090+Nizerlak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nizerlak @christophebedard