New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for GenericPublisher/Subscriber #97
Add test for GenericPublisher/Subscriber #97
Conversation
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
fb6f275
to
24f670a
Compare
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
The The reason why the |
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
f5f8f94
to
ebac435
Compare
@christophebedard |
It looks good to me, but I'm just trying to run the tests with the other rmw implementations too. For some reason I can't get |
Oops, I didn't have |
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: h-suzuki-isp <146712054+h-suzuki-isp@users.noreply.github.com>
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating!
Let's now wait for full CI (under the rclcpp
PR) and perhaps some final reviews for the changes to the rmw
implementations.
Alright, all other PRs have been merged, so I'll merge this one. See ros2/rclcpp#2448 (comment) for CI. Thank you for the contribution @h-suzuki-isp! |
Please, refer to ros2/rclcpp#2448.
Because I added tracepoint for GenericPublisher and GenericSubscriber, I add some tests to test_tracetools.
I have added the following tests.
action-ros-ci-repos-override: https://gist.githubusercontent.com/christophebedard/9a37e393935913add5ad490aaee26e7f/raw/194c464b68cd138e887f041f50f42c0cbe3f4710/ros2.repos