Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specific message when unset parameters are retrieved #104

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Specific message when unset parameters are retrieved #104

merged 1 commit into from
Jun 21, 2018

Conversation

dhood
Copy link
Member

@dhood dhood commented Jun 20, 2018

Without:

$ ros2 param get parameter_node garbage_param
Unknown parameter type '0'

With:

$ ros2 param get parameter_node garbage_param
Parameter not set.

@dhood dhood added the in review Waiting for review (Kanban column) label Jun 20, 2018
@dhood dhood self-assigned this Jun 20, 2018
@dhood dhood requested a review from dirk-thomas June 20, 2018 23:35
@dhood
Copy link
Member Author

dhood commented Jun 21, 2018

(for linters)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dhood dhood merged commit 1d24ad5 into master Jun 21, 2018
@dhood dhood removed the in review Waiting for review (Kanban column) label Jun 21, 2018
@dhood dhood deleted the unset_param_msg branch June 21, 2018 01:28
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
@wjwwood
check for shutdown while waiting for a service response to avoid hang…
c37340d 
… during shutdown (ros2#104)

* check for shutdown while waiting for a service response to avoid hang during shutdown

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix typo in logger call

Signed-off-by: William Woodall <william@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@dirk-thomas dirk-thomas Awaiting requested review from dirk-thomas

Assignees

@dhood dhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhood @wjwwood