Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphasort ros2 node list output. #305

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jul 29, 2019

For node name order to be deterministic. Connected to #304.

For node name order to be deterministic.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic added the enhancement New feature or request label Jul 29, 2019
@hidmic hidmic requested a review from dirk-thomas July 29, 2019 16:02
@hidmic
Copy link
Contributor Author

hidmic commented Jul 29, 2019

AFAIK there are no tests in master for this section of the codebase. It seems to me that running CI is pointless.

@hidmic
Copy link
Contributor Author

hidmic commented Jul 29, 2019

Ok going in!

@hidmic hidmic merged commit 6860105 into master Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/alphasort-node-list branch July 29, 2019 18:52
skucheria pushed a commit that referenced this pull request Jul 30, 2019
For node name order to be deterministic.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* Increase test time tolerance

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants