Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failed modules message #380

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Update failed modules message #380

merged 2 commits into from
Oct 23, 2019

Conversation

maryaB-osr
Copy link
Contributor

The message previously said, for example

Failed modules are  network

Which is confusing when there's only one module

Changing to:

Failed modules: network

Which works if there's one or more failed modules

The message previously said, for example
```
Failed modules are  network
```
Which is confusing when there's only one module

Changing to:
```
Failed modules: network
```
Which works if there's one or more failed modules
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. still gotta run CI lol

@claireyywang
Copy link
Contributor

claireyywang commented Oct 23, 2019

Linux Build Status
Linux-aarch64 Build Status
OSX Build Status
Windows Build Status

@maryaB-osr maryaB-osr merged commit 592a61a into master Oct 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the maryaB-osr-wording branch October 23, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants