Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2node] Make use of include-hidden flag for ros2node info verb #401

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

BMarchi
Copy link
Contributor

@BMarchi BMarchi commented Nov 19, 2019

As the title says, this PR enables the flag for the info verb in ros2node since it was ignored for hidden nodes.

Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
@BMarchi BMarchi requested a review from hidmic November 19, 2019 18:39
@BMarchi
Copy link
Contributor Author

BMarchi commented Nov 25, 2019

  • Linux Build Status
  • Arch Build Status
  • Windows Build Status
  • OSX Build Status

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BMarchi BMarchi merged commit 6b0507e into master Nov 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the BMarchi/fix_hidden_flag_in_info_verb branch November 28, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants