update style to satisfy new flake8 plugins #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
flake8_plugins
branch
from
5f25414
to
9bad4bc
Compare
dirk-thomas
force-pushed
the
flake8_plugins
branch
from
9bad4bc
to
ba56936
Compare
| help="Prefix command, which should go before the executable. " | ||
| "Command must be wrapped in quotes if it contains spaces " | ||
| help='Prefix command, which should go before the executable. ' | ||
| 'Command must be wrapped in quotes if it contains spaces ' |
There was a problem hiding this comment.
looks a bit weird to have part of the multiline string in simple quotes and parts in double quotes. Is there an alternative allowing us to stay consistent regarding quoting within the same string?
There was a problem hiding this comment.
Is there an alternative allowing us to stay consistent regarding quoting within the same string?
No, each string is checked on its own.
mikaelarguedas
approved these changes
Aug 30, 2017
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
yet another exit handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to ros2/ci#98.